Remove regex validation for index_name
#95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
| @@ -227,10 +225,9 @@ def __init__( | |||
| workspace_client: Optional[WorkspaceClient] = None, | |||
| client_args: Optional[Dict[str, Any]] = None, | |||
| ): | |||
| if not (isinstance(index_name, str) and _INDEX_NAME_PATTERN.match(index_name)): | |||
There was a problem hiding this comment.
In the long run, can we check something like this to replace this regex:
if len(model_name.split(".")) != 3:
but I get this is solving the problem of allowing special chars. So we can merge this one
sunishsheth2009
approved these changes
Apr 8, 2025
sunishsheth2009
pushed a commit
that referenced
this pull request
Apr 9, 2025
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
annzhang-db
pushed a commit
that referenced
this pull request
May 7, 2025
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clone of langchain-ai/langchain-databricks#44